Skip to content

Add Arabe #7469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add Arabe #7469

wants to merge 1 commit into from

Conversation

@challal
Copy link

@challal challal commented Aug 27, 2025 •
edited
Loading

Related GitHub Issue

Closes: #

Roo Code Task Context (Optional)

Description

Test Procedure

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Testing: New and/or updated tests have been added to cover my changes (if applicable).
  • Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Screenshots / Videos

Documentation Updates

Additional Notes

Get in Touch

Important

Add Arabic language support to LANGUAGES in language.ts.

  • Language Support:
    • Added Arabic language (ar: "العربية") to LANGUAGES in language.ts.

This description was created by Ellipsis for aba2047. You can customize this summary. It will automatically update as commits are pushed.

@challal challal requested review from cte, jr and mrubens as code owners August 27, 2025 23:37
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 27, 2025
roomote[bot]
roomote bot reviewed Aug 27, 2025
View reviewed changes
Copy link
Contributor

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! I've reviewed the changes and found several critical issues that need to be addressed before this can be merged.

The main concern is that adding Arabic language support requires more than just adding it to the LANGUAGES object. The TypeScript type definitions need to be updated, and the actual translation files need to be created.

src/shared/language.ts
*/

export const LANGUAGES: Record<Language, string> = {
ar: "العربية",
Copy link
Contributor

@roomote roomote bot Aug 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change will cause TypeScript compilation errors. The "ar" value needs to be added to the languages array in packages/types/src/vscode.ts (lines 64-83) for the Language type to recognize it as valid.

Could you also add "ar" to that array to ensure type safety?

src/shared/language.ts
*/

export const LANGUAGES: Record<Language, string> = {
ar: "العربية",
Copy link
Contributor

@roomote roomote bot Aug 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that the Arabic locale directories and translation files are missing from all three locations:

  • src/i18n/locales/ar/
  • webview-ui/src/i18n/locales/ar/
  • locales/ar/

Without these directories and their translation JSON files, the application will fail when users try to switch to Arabic. Could you create these directories and add at least the basic translation files that other languages have?

@roomote
Copy link
Contributor

roomote bot commented Aug 27, 2025

Additionally, I noticed a few administrative items that need attention:

  1. Missing GitHub Issue: The PR template requires linking to an approved GitHub issue, but the "Closes: #" field is empty. Per the contribution guidelines, every PR must be linked to an approved issue. Could you create an issue first or link to an existing one?

  2. PR Title: There appears to be a typo - "Add Arabe" should be "Add Arabic" for correct English spelling.

  3. Incomplete PR Template: Several sections of the PR template need to be filled out:

    • Description of how the changes address the issue
    • Test procedure details
    • Pre-submission checklist items need to be checked

These administrative items help maintain project quality and make the review process smoother. Thank you for your understanding!

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Aug 27, 2025
@challal challal closed this Aug 27, 2025
@challal challal deleted the patch-1 branch August 27, 2025 23:51
@challal challal restored the patch-1 branch August 27, 2025 23:51
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Aug 27, 2025
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Aug 27, 2025
@challal challal deleted the patch-1 branch August 27, 2025 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roomote roomote[bot] roomote[bot] left review comments

@mrubens mrubens Awaiting requested review from mrubens mrubens is a code owner

@cte cte Awaiting requested review from cte cte is a code owner

@jr jr Awaiting requested review from jr jr is a code owner

Assignees

No one assigned

Labels

Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Roo Code Roadmap
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@challal @hannesrudolph